Re: [PATCH v4] IB/core: Make device counter infrastructure dynamic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 20, 2016 at 12:14:47PM -0400, Doug Ledford wrote:
> +static const char *names[] = {

What is wrong with

 static const char * const names[] = {

As I originally suggested? No reason for the array to be .data that I
can see.

> +	/* Guard against buggy edits of the names array */
> +	BUILD_BUG_ON(ARRAY_SIZE(names) != NR_COUNTERS);

Just drop NR_COUNTERS an use ARRAY_SIZE(names) in all places
instead?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux