> -----Original Message----- > From: Jason Gunthorpe [mailto:jgunthorpe@xxxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, May 17, 2016 12:03 AM > To: Doug Ledford <dledford@xxxxxxxxxx> > Cc: leon@xxxxxxxxxx; Mark Bloch <markb@xxxxxxxxxxxx>; linux- > rdma@xxxxxxxxxxxxxxx > Subject: Re: [PATCH rdma-next V2 5/5] IB/core: Integrate IB address > resolution module into core > > > and things are broken for some period of time. If the change to ib_addr > > actually solved a problem that couldn't be solved otherwise, that would > > be one thing. But it doesn't. It's a complete no-op. > > The original patches had a horrible dynamic registration scheme for > the netlink dispatch that only served to work around the pointless > module split. The issue is that the dispatch needs to have function > relocations from both modules to follow the usual netlink idioms. Are you talking about the changes in ibnl_add_client? Those changes were because of a different module (ib_sa.ko) In sa_query.c we register a ibnl client for RDMA_NL_LS and we use that for getting path records (ibacm runs in userspace and listens on that netlink socket). If we look at the definition of RDMA_NS_LS it is defined as a rdma local service operations, so naturedly I feel ip->gid should be added to that family. It means we have two modules (ib_sa.ko and ib_core/ib_addr depends if we integrate them or not) Needing to use different operations which are part of the same family. The approach I've chosen is the easiest to implement because I'm not sure we need all the complexity other solutions impose. I think Ira suggested to introduce "add operation" it's an idea I've thought about, but it raises the issue of ibnl needing to manage each family. This idea has the benefit if we want to have an overlap between clients, can you think of a use case where different clients need to support the same operation? I should also mention the option of adding a new family RDMA_NL_LS_IP or something like that. I didn't do that because we are using ibacm to answer the ip->gid requests. Ibacm already listens on a netlink socket for RDMA_NS_LS, so it makes adding Ip->gid to ibacm much easier and nicer if it needs to listen on only one netlink socket. > It is unfortunate that distro scripts have become such that they break > if the kernel changes even something small like dependencies. > > Another alternative is to move only the parts of ib_addr that touch > netlink into ib_core. Hopefully that doesn't create an empty module. > > Jason Mark -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
