> -----Original Message----- > From: Jason Gunthorpe [mailto:jgunthorpe@xxxxxxxxxxxxxxxxxxxx] > Sent: Friday, May 13, 2016 7:46 PM > To: Mark Bloch <markb@xxxxxxxxxxxx> > Cc: Leon Romanovsky <leon@xxxxxxxxxx>; dledford@xxxxxxxxxx; linux- > rdma@xxxxxxxxxxxxxxx; Majd Dibbiny <majd@xxxxxxxxxxxx>; Matan Barak > <matanb@xxxxxxxxxxxx> > Subject: Re: [PATCH rdma-next] IB/IPoIB: Allow setting the device address > > On Tue, May 10, 2016 at 03:26:27PM +0000, Mark Bloch wrote: > > > > Did these checks from eth_prepare_mac_addr_change get included? > > > > > > if (!(dev->priv_flags & IFF_LIVE_ADDR_CHANGE) && > > > netif_running(dev)) > > > return -EBUSY; > > > > > Why do I need to include that? > > That is standard in all the other implementations - you should be > asking instead why IPoIB doesn't need to copy that. What I've meant is that I don't see why IPoIB won't support live address change. Having said that, it seems IPv6 multicast group membership has issues with live address change. I'll add the if to the next patch version. Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
