On 05/12/2016 01:44 PM, Leon Romanovsky wrote: > Hi Doug, > > I prepared the base tree [1] with patches sent to RDMA mailing and passed review. You can't know that. The reason I say that is because they have to pass my review as well, and that's usually an implicit thing. If I review them and they have already passed list review and they pass my review, then I include them. If they don't pass my review (which isn't often if the other people on the list have already spoke up, but does happen), then I ask for revisions. If you take them without an explicit review from me, then you don't know if I'll ask for a revision or not. It's premature. > This base tree is part of linux-next and kbuild system, and it passed > sanity checks. Most, there was a linux-next build failure that I'm sure is related to a change I hadn't had a chance to look into yet but looked fishy to me (the move to put ib_addr into ib_core looks like it's broken, but I hadn't delved into the code to verify it...the linux-next build failure from tonight makes me thing that it is). > I believe that it will save you a lot of work and time if you use it > as a base for next merge window submission (4.7). Not really. I still have to review the patches, and I still have to update patchworks, and when I'm sorting through patchworks is when I get the patches to include. The incremental time to grab the patches out of patchworks and run git am -s on the bundle is negligible. The real time is in reading the patches, and this doesn't save me any of that time. The help is appreciated though ;-) > The topics which were added: > * topic/fix-core > * topic/hfi1 > * topic/i40iw > * topic/ipoib > * topic/iw_cxgb4 > * topic/iwcm > * topic/nes > * topic/rdma-rw-api > * topic/srp > > [1] > Git repository: > git://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git rdma-next > > Gitweb: > https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/log/?h=rdma-next > > Thanks. > -- Doug Ledford <dledford@xxxxxxxxxx> GPG KeyID: 0E572FDD
Attachment:
signature.asc
Description: OpenPGP digital signature
