On 5/5/2016 7:36 AM, Erez Shitrit wrote:
> Change struct ib_class_port_info to conform to IB Spec 1.3
> That in order to get specific capability mask from ClassPortInfo mad.
>
>>From the IB Spec, ClassPortInfo section:
> "CapabilityMask2 Bits 0-26: Additional class-specific capabilities...
> RespTimeValue the rest 5 bits"
>
> The new struct now has one field for capabilitymask2 (previously was the
> reserved field) and the resp_time field.
>
> And it fixes up qib use of the field repurposed to be used as capabilitymask2:
> IB/qib: Change pma_get_classportinfo
>
> Signed-off-by: Erez Shitrit <erezsh@xxxxxxxxxxxx>
> Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
> drivers/infiniband/hw/qib/qib_mad.c | 4 +++-
> include/rdma/ib_mad.h | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
> index 0bd1837..c5f6248 100644
> --- a/drivers/infiniband/hw/qib/qib_mad.c
> +++ b/drivers/infiniband/hw/qib/qib_mad.c
> @@ -1158,6 +1158,7 @@ static int pma_get_classportinfo(struct ib_pma_mad *pmp,
> struct ib_class_port_info *p =
> (struct ib_class_port_info *)pmp->data;
> struct qib_devdata *dd = dd_from_ibdev(ibdev);
> + char *p_cap_mask2;
>
> memset(pmp->data, 0, sizeof(pmp->data));
>
> @@ -1172,7 +1173,8 @@ static int pma_get_classportinfo(struct ib_pma_mad *pmp,
> * Set the most significant bit of CM2 to indicate support for
> * congestion statistics
> */
> - p->reserved[0] = dd->psxmitwait_supported << 7;
> + p_cap_mask2 = (char *)&p->capability_mask2;
> + p_cap_mask2[0] = dd->psxmitwait_supported << 7;
> /*
> * Expected response time is 4.096 usec. * 2^18 == 1.073741824 sec.
> */
> diff --git a/include/rdma/ib_mad.h b/include/rdma/ib_mad.h
> index 37dd534c..0761ab9 100644
> --- a/include/rdma/ib_mad.h
> +++ b/include/rdma/ib_mad.h
> @@ -243,7 +243,7 @@ struct ib_class_port_info {
> u8 base_version;
> u8 class_version;
> __be16 capability_mask;
> - u8 reserved[3];
> + __be32 capability_mask2;
> u8 resp_time_value;
This looks wrong to me as CapabilityMask2 is 27 bits and RespTimeValue
is the remaining 5 bits in a 32 bit field in ClassPortInfo attribute.
-- Hal
> u8 redirect_gid[16];
> __be32 redirect_tcslfl;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
