On Tue, Apr 26, 2016 at 11:57 PM, Hefty, Sean <sean.hefty@xxxxxxxxx> wrote: >> > +* There are 4 types of join states: >> > +* FullMember, NonMember, SendOnlyNonMember, SendOnlyFullMember. >> > +*/ >> > +enum { >> > + FULLMEMBER_JOIN, >> > + NONMEMBER_JOIN, >> > + SENDONLY_NONMEBER_JOIN, >> > + SENDONLY_FULLMEMBER_JOIN, >> > + NUM_JOIN_MEMBERSHIP_TYPES = 4 > > These seem better suited as flags -- fullmember (y/n), sendonly (y/n) The ib_core tracks over the number of members for each join types, in order not to double join from specific port to specific join type. It keeps the numbers of members in special array, entry for each join type. So, the meaning of the enum is to define the size of the that array and not to define a bit mask. > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html