RE: [PATCH V1 for-next 1/2] IB/core: Report LSO capabilities when querying device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +struct ib_lso_caps {
> > +	u32 max_lso;
> > +	u32 supported_qpts; /* Use enum ib_qp_type */
> 
> So this is a bitmap of the qps supported? And thus we have a limit now of
> 32 QP types. That needs to be documented and  you need a BUILD_BUG_ON
> somewhere in case IB_QPT_MAX becomes larger than 32. Also needs to be
> better commented so we know this is a bitmap.

I think it would make more sense to indicate what protocol, or specific aspect of a protocol, are being offloaded.  Some qp types support LSO as a matter of practice.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux