On Sun, Apr 24, 2016 at 05:48:53PM -0700, Bart Van Assche wrote: > On 04/24/16 01:35, Leon Romanovsky wrote: > >On Fri, Apr 22, 2016 at 02:16:31PM -0700, Bart Van Assche wrote: > >>+ max_max_sectors = (srp_dev->max_pages_per_mr - 1) << > >>+ (ilog2(srp_dev->mr_page_size) - 9); > > > > From my understanding, srp_dev->max_pages_per_mr can be equal to 1, in > >case device will advertise it. > > > >Is this understanding correct? > >Will the code work in such case? > > Hello Leon, > > I'm not sure a HCA driver exists for which max_pages_per_mr == 1. > Additionally, I'm not sure such a driver would be useful because such a > driver would limit the maximum data transfer size for the iSER protocol to 4 > KB. That is too low to reach good performance. Bart and Laurence, You are raising valuable arguments about sanity of setting srp_dev->max_pages_per_mr to be equal 1. I totally agree with you that it is insane, however my original question was "does the code support such value?" > > Bart. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: Digital signature
