On Mon, Apr 18, 2016 at 02:42:22PM -0400, David Woodhouse wrote:
> On Mon, 2016-04-18 at 15:30 +0300, Leon Romanovsky wrote:
> > From the name of that function looks that the parameter supplied
> > should be ENUM, but it is not the case.
>
> The implicit question might, perhaps, be "why?" :)
OPA defines MTU values which are not "ib_mtu" enumerations. This code is
processing 2 different "types" of enumerations. The IB compatible ones as well
as new ones which are specific to OPA.
The OPA enums are not defined as a type but perhaps they should be?
>From include/rdma/opa_port_info.h:
enum {
OPA_MTU_8192 = 6,
OPA_MTU_10240 = 7,
};
Also I just noticed this comment for the function which is no longer
appropriate:
...
* The actual flag used to determine "8k MTU" will change and is currently
* unknown.
...
We should remove the comment.
Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
