Re: [PATCH 0/4] IB/srpt and the percpu_ida conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2016-04-06 at 11:56 -0700, Bart Van Assche wrote:
> Hi Doug,
> 
> This patch series addresses the recently reported issue with regard to 
> the percpu_ida conversion of the ib_srpt driver. My proposal is to 
> submit patch 1/4 for inclusion in kernel v4.6 and to submit patches 2..4 
> for inclusion in kernel v4.7. The actual patches in this series are:
> 
> 0001-IB-srpt-Revert-Convert-to-percpu_ida-tag-allocation.patch
> 0002-IB-srpt-Report-login-failures-only-once.patch
> 0003-IB-srpt-Introduce-two-helper-functions.patch
> 0004-IB-srpt-Convert-to-percpu_ida-tag-allocation.patch
> 

I asked to not revert the percpu_ida conversion and again you simply
ignored subsystem maintainer feedback, and included a different
percpu_ida conversion without using alloc_session callback that still
does pre-allocation of buffers before session login even completes.

The whole point of the alloc_session callback is so that extra
pre-allocation doesn't happen until after se_node_acl lookup has
finished, and is what ib_srpt needs to be using given SRP's completely
existent spec level security model.

In any event, I'm fixing the regression ahead of the next v4.6-rc PULL
in:

http://www.spinics.net/lists/target-devel/msg12535.html

Any issues you find with this patch should be sent out as an incremental
patch, and not rolling your own concoction.









--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux