On 4/7/2016 11:31 AM, Leon Romanovsky wrote:
> On Thu, Apr 07, 2016 at 02:33:54AM +0300, Dan Jurgens wrote:
>> From: Daniel Jurgens <danielj@xxxxxxxxxxxx>
>> drivers/infiniband/core/core_priv.h | 41 ++++
>> drivers/infiniband/core/core_security.c | 331 +++++++++++++++++++++++++++++++
>
> We are already in core, there is no need to call files core_XXX.
I can change core_security.c to security.c. core_priv.h already existed
so I won't change that in this patch.
>> +int ib_security_create_qp_security(struct ib_qp *qp);
>
> Why do we need xx_SECURITY_xxxxx_SECURITY in name?
I had called it ib_security_create_qp. Eli thought that implied more
work that it actually does. All the none static functions are named
ib_security_xxx, which I kind of liked as a convention, but I can
abandon that and go with ib_create_qp_security.
>> + return check_pkey && (qp->qp_num != IB_QPT_SMI &&
>> + qp->qp_num != IB_QPT_GSI);
>
> IB_QPT_SMI and IB_QPT_GSI are declared as struct ib_qp_type and setted
> in qp->qp_type and not in qp->qp_num.
>> +}
>> +
>> +static int check_alt_pkey(const struct ib_qp *qp,
>> + const struct ib_qp_attr *qp_attr,
>> + int qp_attr_mask)
>> +{
>> + bool check_alt_pkey = !!(qp_attr_mask & IB_QP_ALT_PATH);
>> +
>> + return check_alt_pkey && (qp->qp_num != IB_QPT_SMI &&
>> + qp->qp_num != IB_QPT_GSI);
>> +}
>
> The same as above.
I'll fix this.
>> + kfree(qp->qp_sec);
>> +
>> + return err;
>> +}
>> +EXPORT_SYMBOL(ib_security_create_qp_security);
>> +
>> +void ib_security_destroy_qp(struct ib_qp_security *sec)
>> +{
>> + security_ib_qp_free_security(sec);
>> + kfree(sec);
>> +}
>
> Did you want to EXPORT_SYMBOL here too?
>
It's not called from outside ib_core, I only exported the functions that
are. ib_security_modify_qp and ib_security_create_qp security are called
from ib_core and ib_uverbs. ib_security_enforce_mad_agent_pkey_access
is called from ib_mad.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
