On 4/6/2016 9:53 PM, Leon Romanovsky wrote: > On Thu, Apr 07, 2016 at 02:33:53AM +0300, Dan Jurgens wrote: >> From: Daniel Jurgens <danielj@xxxxxxxxxxxx> >> >> + int ret = 0; > > It is not needed, just return 0 directly. Okay On 4/7/2016 10:24 AM, Leon Romanovsky wrote: > On Thu, Apr 07, 2016 at 02:33:53AM +0300, Dan Jurgens wrote: >> pr_warn("Couldn't allocate cache for %s\n", device->name); > > Please remove this print. You won't miss failure in memory allocation. Sure, I can do that. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html