On Tue, Apr 05, 2016 at 03:32:53PM +0800, oulijun wrote: > >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 ++++++++++++++++++++ > >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++++++ > > ^^^^^^ > > Do you support v1 of RoCE or v1 of your HW? > > > Here, v1 stands for hw, that is, we support v1 of our hw. So you should write hns_roce_hw_v1 and not hns_roce_v1_hw > >> 23 files changed, 10429 insertions(+) > > > > Please appreciate the effort needed to review such large patch and > > invest time and effort to divide this to number of small easy review patches. > > > Surely, i have pay attention to the patch, but i consider that it is not better to > split the patch into small patch. because it will the base function of RoCE. > For your advice, i will make further efforts to taking a discussion how to reslove the question. Faisal Latif's submission [1] can help you to get inspiration. Also please DON'T submit your patches till you get rid of unrelated functions/macros/defines and DMA operations for register access. [1] https://lwn.net/Articles/668721/ > > thanks > Lijun Ou > > . > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
