On Fri, Mar 18, 2016 at 09:33:28AM -0500, Christoph Lameter wrote: > On Fri, 18 Mar 2016, Leon Romanovsky wrote: > > > It makes the stat.name check redundant. Do you have scenario in mind > > where ret == 0 and stat.name == NULL as a result of call to the > > function? > > This is a function provided by those writing the device drivers. Better > check that the function filled out at least one required value. > I don't have any objections with this code either, just worried about patch bots like we saw a couple of months before. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html