Hi Tejun, On Thu, Mar 17, 2016 at 2:10 AM, Tejun Heo <tj@xxxxxxxxxx> wrote: > >> If this is ok. I will keep the code as it is, because it uses common >> helper functions for max and current files. > > Hmmm... can you please try to refactor the common part to helpers? > It's not a big thing but there were both styles across different > controllers and helper based ones tend to be easier to follow. > in this v9 patch, To read max and current value, entry point is common function rdmacg_resource_read(). This is due to the fact that reading max and current needs to do same thing. Exceptions are taken care in below helper functions. It uses two small helper functions 1. get_cg_rpool_values 2. print_rpool_values Can I continue with this approach? > I see, but if that's the case, please drop the fine locking. The fine > locking doesn't make much sense - as implemented it's slower and the > whole thing is not hot. o.k. Also can you please confirm that once patch looks good to you, you are ok to merge this patch from Doug's linux-rdma tree as merge is clean from that tree? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
