Re: [PATCH v4 9/9] IB/srpt: convert to the generic RDMA READ/WRITE API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/09/2016 04:59 AM, Christoph Hellwig wrote:
You can jump to unwind label from one place only. In that stage
"ioctx->rw_ctxs != NULL" will always be true.

There's two places actually, but it can't be NULL for both, so I
will removed that condition.

I'll update the git tree with the current review feedback, but I'll
wait for you to finish the review before resending it.

Since it is safe to pass NULL to kfree() I think a similar comment applies to srpt_free_rw_ctxs() and that also from that function "ioctx->rw_ctxs && " can be left out.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux