On Tue, Mar 08, 2016 at 01:38:20PM -0600, Steve Wise wrote: > > On Tue, Mar 08, 2016 at 07:16:32PM +0100, Christoph Hellwig wrote: > > > The new RW API will need this. > > > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > Tested-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx> > > > --- > > > drivers/infiniband/core/cma.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c > > > index 9729639..a791522 100644 > > > --- a/drivers/infiniband/core/cma.c > > > +++ b/drivers/infiniband/core/cma.c > > > @@ -800,6 +800,7 @@ int rdma_create_qp(struct rdma_cm_id *id, struct ib_pd *pd, > > > if (id->device != pd->device) > > > return -EINVAL; > > > > > > + qp_init_attr->port_num = id->port_num; > > > > I doubt whether this is the right place to update qp_init_attr structure. > > Maybe the better solution will be to update the callers of rdma_create_qp? > > It will place all qp_init_attr assignments in one place. > > At the expense of replicating this code and forcing all users to remember to set this. There are no much such users to update, these users need to set qp_init_attr structure anyway. > > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
