Re: [PATCH rdma-next V1 04/10] IB/core: Support accessing SA in virtualized environment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 07, 2016 at 11:08:54PM +0200, Eli Cohen wrote:

> +enum {
> +	IB_SA_WELL_KNOWN_GUID	= 2,
> +};

Where did this come from?

It is wrong to have a EUI-64 like this that has a 0 OUI.

It is wrong to have a 'well known GUID' that is by definition not
universal without setting the local bit (IBA spec even says this)

The well known guid should still conform to IEEE rules for creating
EUI-64s.

Note, that the IBA is a little confused because it tries to follow
IPv6 rules in some places not realizing that IPv6 uses an EUI-64 with
the U/L bit inverted.

IMHO, new constants should strictly follow the IEEE EUI-64 rules and
not try and confuse matters futher. The unused, incorrect, IBA
definition of ::1 should be ignored.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux