On Tue, Feb 23, 2016 at 11:44:00AM -0700, Jason Gunthorpe wrote: > On Tue, Feb 23, 2016 at 10:25:27AM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > > > This vector CALC feature allows different offloaded arithmetic > > calculations of several vectors of equal length. > > > > In order to properly use this feature, the user space applications > > need to know the supported properties, like operations, size and > > maximal number of vectors. > > > > The properties exposed are: > > * calc_matrix - If set, vector CALC matrix is supported. > > * max_vector_count - Maximum number of vectors supported. > > * max_chunk_size - Maximum chunk size supported. > > This kind of stuff should be in a kdoc not lost in a commit message. > > > * op_cap - Bit mask indicates which vector CALC operations are supported: > > Bit 1: ADD operation > > Bit 2: MAX operation > > Bit 3: AND operation > > Bit 4: OR operation > > Bit 5: XOR operation > > Bit 6: MIN operation > > Bit 7: SWAP_ENDIANNESS operation > > This should be constants in the uAPI header. > > A commit message is not documentation. Sorry for not actively participating in this discussion, I was traveling with terrible internet access. I'll be more than happy to send the version with your concerns fixed. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
