On Sunday 28 February 2016 15:26:53 Saeed Mahameed wrote: > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > > index 0d45f35aee72..44fc4bc35ffd 100644 > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > > @@ -2116,6 +2116,9 @@ static netdev_features_t mlx5e_vxlan_features_check(struct mlx5e_priv *priv, > > u16 proto; > > u16 port = 0; > > > > + if (!IS_ENABLED(CONFIG_MLX5_CORE_EN_VXLAN)) > > + goto out; > > + > > I would rather wrap the whole mlx5e_features_check with the suggested > config flag and disable it in case CONFIG_MLX5_CORE_EN_VXLAN is OFF, > since this function is only needed for when vxlan is supported. Sounds good. I think moving the IS_ENABLED() check into the caller(s) will still result in the same object code, but it makes sense to structure the code for best readability. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
