On 2/17/2016 11:59 PM, Leon Romanovsky wrote: > Please see my minor comments below. > Reviewed-by: Leon Romanovsky <leon@xxxxxxx> > > On Wed, Feb 17, 2016 at 01:06:33PM -0500, Insu Yun wrote: >> Since create_singlethread_workqueue uses kzalloc internally, >> it can be failed in memory pressure, so need to handle it. > > s/can be failed/can fail/ > >> >> Signed-off-by: Insu Yun <wuninsu@xxxxxxxxx> >> --- >> drivers/infiniband/hw/nes/nes_cm.c | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c >> index cb9f0f2..23afad6 100644 >> --- a/drivers/infiniband/hw/nes/nes_cm.c >> +++ b/drivers/infiniband/hw/nes/nes_cm.c >> @@ -2833,7 +2833,7 @@ static struct nes_cm_core *nes_cm_alloc_core(void) >> /* alloc top level core control structure */ >> cm_core = kzalloc(sizeof(*cm_core), GFP_KERNEL); >> if (!cm_core) >> - return NULL; >> + goto enomem_3; > > IMHO, there is no need to define goto label for one return. I made the touchups Leon suggested, and a touchup of my own, but it is now applied, thanks.
Attachment:
signature.asc
Description: OpenPGP digital signature
