On Fri, Feb 12, 2016 at 12:13:28PM -0800, Christoph Hellwig wrote: > On Thu, Feb 11, 2016 at 12:18:38PM -0700, Jason Gunthorpe wrote: > > Most of this stuff (eg the whole peer_memory_client thing) has no > > buisness being part of the RDMA stack. We can't ask other drivers to > > call IB functions just because their devices have ZONE_DIRECT memory. > > > > Resubmit those parts under the mm subsystem, or another more > > appropriate place. > > > > This is the same comment as last time this was submitted. > > > > If you want to make some incremental progress then implement the > > existing ZONE_DEVICE API for the IB core and add the invalidate stuff > > later, once you've negotiated a common API for that with linux-mm. > > Agreed on all points. Nevermind that seems to be missing a user of all > the newly added infrastructure, which should come with the series. Yep! I've heard from the people working on NVMe cards that this approach isn't needed, desired, or correct. I'm deeply skeptical that there would be an in-kernel user. AFAIK, this specific interface is only needed to support nvidia's propritary kernel module, which has some oddball design where these extra callbacks are needed. But who knows, maybe someone can think up reason why filesystems might want to do an invalidate as well. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
