> -----Original Message----- > From: Sagi Grimberg [mailto:sagig@xxxxxxxxxxxxxxxxxx] > Sent: Sunday, February 07, 2016 5:52 AM > To: Steve Wise; linux-rdma@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/3] IB: new common API for draining a queue pair > > > >> + ret = ib_modify_qp(qp, &attr, IB_QP_STATE); > >> + if (ret) { > >> + WARN_ONCE(ret, "failed to drain QP: %d\n", ret); > >> + return; > >> + } > >> + > >> + ret = ib_post_recv(qp, &rwr, &bad_rwr); > >> + if (ret) { > >> + WARN_ONCE(ret, "failed to drain recv queue: %d\n", ret); > >> + return; > >> + } > >> + > >> + ret = ib_post_send(qp, &swr, &bad_swr); > >> + if (ret) { > >> + WARN_ONCE(ret, "failed to drain send queue: %d\n", ret); > >> + return; > > > > You are returning here despite the fact that recv queue drained > > successfully and you can wait for completion of rdrain safely. > > Is it done on purpose? > > Good catch, the completion structures are on-stack. > > Steve, you need to wait for the completion of the > successful post in this case... Yup. Will do. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
