Hi Leon, > A number of very minor comments: > 1. Please remove dot at the end of commit message title. > Ok. Thanks. > 2. This function declared as a void, it is an error to add "return 0". > ipoib_mcast_join() is declared as int. Please see a very first change. > -static void ipoib_mcast_join(struct net_device *dev, struct ipoib_mcast *mcast) > +static int ipoib_mcast_join(struct net_device *dev, struct ipoib_mcast *mcast) > 3. There is no need to compare with 0. Just use "if (ipoib...(...))" > construction. Ok. No problem. Thanks, Alex. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
