On Sun, Feb 7, 2016 at 5:23 PM, Sagi Grimberg <sagig@xxxxxxxxxxxxxxxxxx> wrote:
>
>>> +/*
>>> + * Post a WR and block until its completion is reaped for both the RQ
>>> and SQ.
>>> + */
>>> +static void __ib_drain_qp(struct ib_qp *qp)
>>> +{
>>> + struct ib_qp_attr attr = { .qp_state = IB_QPS_ERR };
>>> + struct ib_drain_cqe rdrain, sdrain;
>>> + struct ib_recv_wr rwr = {}, *bad_rwr;
>>> + struct ib_send_wr swr = {}, *bad_swr;
>>> + int ret;
>>> +
>>> + rwr.wr_cqe = &rdrain.cqe;
>>> + rdrain.cqe.done = ib_drain_qp_done;
>>> + init_completion(&rdrain.done);
>>> +
>>> + swr.wr_cqe = &sdrain.cqe;
>>> + sdrain.cqe.done = ib_drain_qp_done;
>>> + init_completion(&sdrain.done);
>>> +
>>> + ret = ib_modify_qp(qp, &attr, IB_QP_STATE);
>>> + if (ret) {
>>> + WARN_ONCE(ret, "failed to drain QP: %d\n", ret);
>>> + return;
>>> + }
>>
>>
>> I was thinking if we really need this modify_qp here. generally
>> drain_qp is called on
>> an error'ed out QP. In a graceful tear down rdma_disconnect takes care
>> to modify-qp
>> to error. while in error state qp is already in error state.
>
>
> We could get it conditional, but I don't see any harm done
> in having it as it would mean a passed in flag.
>
Since Spec allows this, I would say okay let it be there.
> It would be better to have the modify_qp implementers do
> nothing for a ERROR -> ERROR modify...
Driver implementer has a choice here which is okay.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
