Looks good.
Reviewed-by: Alex Estrin <alex.estrin@xxxxxxxxx>
> Inline those CM callback functions that are only two lines long.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Sagi Grimberg <sagig@xxxxxxxxxxxx>
> ---
> drivers/infiniband/ulp/srpt/ib_srpt.c | 31 +++++++------------------------
> 1 file changed, 7 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c
> b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index 652e1ef..5e4fee7 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -2315,18 +2315,6 @@ static void srpt_cm_rtu_recv(struct ib_cm_id *cm_id)
> }
> }
>
> -static void srpt_cm_timewait_exit(struct ib_cm_id *cm_id)
> -{
> - pr_info("Received IB TimeWait exit for cm_id %p.\n", cm_id);
> - srpt_drain_channel(cm_id);
> -}
> -
> -static void srpt_cm_rep_error(struct ib_cm_id *cm_id)
> -{
> - pr_info("Received IB REP error for cm_id %p.\n", cm_id);
> - srpt_drain_channel(cm_id);
> -}
> -
> /**
> * srpt_cm_dreq_recv() - Process reception of a DREQ message.
> */
> @@ -2365,15 +2353,6 @@ static void srpt_cm_dreq_recv(struct ib_cm_id *cm_id)
> }
>
> /**
> - * srpt_cm_drep_recv() - Process reception of a DREP message.
> - */
> -static void srpt_cm_drep_recv(struct ib_cm_id *cm_id)
> -{
> - pr_info("Received InfiniBand DREP message for cm_id %p.\n", cm_id);
> - srpt_drain_channel(cm_id);
> -}
> -
> -/**
> * srpt_cm_handler() - IB connection manager callback function.
> *
> * A non-zero return value will cause the caller destroy the CM ID.
> @@ -2404,13 +2383,17 @@ static int srpt_cm_handler(struct ib_cm_id *cm_id, struct
> ib_cm_event *event)
> srpt_cm_dreq_recv(cm_id);
> break;
> case IB_CM_DREP_RECEIVED:
> - srpt_cm_drep_recv(cm_id);
> + pr_info("Received InfiniBand DREP message for cm_id %p.\n",
> + cm_id);
> + srpt_drain_channel(cm_id);
> break;
> case IB_CM_TIMEWAIT_EXIT:
> - srpt_cm_timewait_exit(cm_id);
> + pr_info("Received IB TimeWait exit for cm_id %p.\n", cm_id);
> + srpt_drain_channel(cm_id);
> break;
> case IB_CM_REP_ERROR:
> - srpt_cm_rep_error(cm_id);
> + pr_info("Received IB REP error for cm_id %p.\n", cm_id);
> + srpt_drain_channel(cm_id);
> break;
> case IB_CM_DREQ_ERROR:
> pr_info("Received IB DREQ ERROR event.\n");
> --
> 2.7.0
��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
