On Tue, Jan 26, 2016 at 04:54:18PM +0200, Leon Romanovsky wrote:
> On Tue, Jan 26, 2016 at 04:56:23AM -0800, Yuval Shaia wrote:
> > Expose driver version so admin can query it.
> > Initial version set to 3.18.1 as 3.18 is the latest OFED version.
> >
> > Signed-off-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
> > ---
> > drivers/infiniband/core/cm.c | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
> > index 1d92e09..cb5dfeb 100644
> > --- a/drivers/infiniband/core/cm.c
> > +++ b/drivers/infiniband/core/cm.c
> > @@ -53,9 +53,12 @@
> > #include <rdma/ib_cm.h>
> > #include "cm_msgs.h"
> >
> > +#define DRV_VERSION "3.18.1"
> > +
>
> I recommend to drop this line instead of exposing.
> The proper way is to use kernel version and not
> specific module version which is unrelated to
> anything in the real world.
Are you suggesting not to use MODULE_VERSION at all?
Asking because i see many drivers (>600) that use it.
>
> > MODULE_AUTHOR("Sean Hefty");
> > MODULE_DESCRIPTION("InfiniBand CM");
> > MODULE_LICENSE("Dual BSD/GPL");
> > +MODULE_VERSION(DRV_VERSION);
> >
> > static void cm_add_one(struct ib_device *device);
> > static void cm_remove_one(struct ib_device *device, void *client_data);
> > --
> > 1.7.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
