Re: [PATCH][V2] IB/sysfs: remove unused va_list args

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 25, 2016 at 06:38:06PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> _show_port_gid_attr performs a va_end on some unused va_list args.
> Clean this up by removing the args completely.
> 
> Fixes: 470be516a226e8 ("IB/core: Add gid attributes to sysfs")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>

> ---
>  drivers/infiniband/core/sysfs.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
> index 3de9351..ec46386 100644
> --- a/drivers/infiniband/core/sysfs.c
> +++ b/drivers/infiniband/core/sysfs.c
> @@ -336,7 +336,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
>  	union ib_gid gid;
>  	struct ib_gid_attr gid_attr = {};
>  	ssize_t ret;
> -	va_list args;
>  
>  	ret = ib_query_gid(p->ibdev, p->port_num, tab_attr->index, &gid,
>  			   &gid_attr);
> @@ -348,7 +347,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
>  err:
>  	if (gid_attr.ndev)
>  		dev_put(gid_attr.ndev);
> -	va_end(args);
>  	return ret;
>  }
>  
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux