Hey Matan, Will you please submit this to 4.4-stable? Thanks, Steve. > -----Original Message----- > From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma-owner@xxxxxxxxxxxxxxx] On Behalf Of Matan Barak > Sent: Thursday, January 07, 2016 3:19 AM > To: Doug Ledford > Cc: linux-rdma@xxxxxxxxxxxxxxx; Or Gerlitz; Majd Dibbiny; Hariprasad Shenai; Matan Barak > Subject: [PATCH V1] IB/cma: Fix RDMA port validation for iWarp > > cma_validate_port wrongly assumed that Ethernet devices are RoCE > devices and thus their ndev should be matched in the GID table. > This broke the iWarp support. Fixing that matching the ndev only if > we work on a RoCE port. > > Fixes: abae1b71dd37 ('IB/cma: cma_validate_port should verify the port > and netdevice') > Reported-by: Hariprasad Shenai <hariprasad@xxxxxxxxxxx> > Tested-by: Hariprasad Shenai <hariprasad@xxxxxxxxxxx> > Signed-off-by: Matan Barak <matanb@xxxxxxxxxxxx> > --- > > Hi Doug, > > This patch fixes an iWarp issue that was introduced in the RoCE > refactoring series. > > Regards, > Matan > > Changes from V0: > - Fixed typo > > drivers/infiniband/core/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c > index 2d762a2..17a15c5 100644 > --- a/drivers/infiniband/core/cma.c > +++ b/drivers/infiniband/core/cma.c > @@ -453,7 +453,7 @@ static inline int cma_validate_port(struct ib_device *device, u8 port, > if ((dev_type != ARPHRD_INFINIBAND) && rdma_protocol_ib(device, port)) > return ret; > > - if (dev_type == ARPHRD_ETHER) > + if (dev_type == ARPHRD_ETHER && rdma_protocol_roce(device, port)) > ndev = dev_get_by_index(&init_net, bound_if_index); > > ret = ib_find_cached_gid_by_port(device, gid, port, ndev, NULL); > -- > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
