On Tue, Jan 05, 2016 at 03:25:13PM +0100, Bart Van Assche wrote: > The target core function that should be called if target_submit_cmd() > fails is target_put_sess_cmd(). Additionally, change the return type > of srpt_handle_cmd() from int into void. I actually ran into this bug a long time ago with a modified srpt driver and forgot to send a similar fix.. Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> Minor nitpick below: > + send_ioctx->state = SRPT_STATE_DONE; > + target_put_sess_cmd(cmd); > + return; > } no need for that return statement. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html