On Tue, Jan 05, 2016 at 03:23:45PM +0100, Bart Van Assche wrote: > The only allowed channel state changes are those that change > the channel state into a state with a higher numerical value. > This allows to merge the functions srpt_set_ch_state() and > srpt_test_and_set_ch_state() into a single function. It would be great having a little comment in srpt_set_ch_state explaining why only changing to the numerical greater state is fine. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html