On Mon, Jan 4, 2016 at 5:44 AM, <ira.weiny@xxxxxxxxx> wrote:
> From: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> Attributed ID was declared as an int while the value should really be big
> endian 16.
>
> Fixes: 35c4cbb17811 ("IB/core: Create get_perf_mad function in sysfs.c")
>
remove this blank line (&& I provided you this comment multiple times
in the past)
> Reported-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
reverse the order, your S.O.B sig line should come 1st and later the rest of
the reporters/ackers/testers/maintainers notes
> ---
> drivers/infiniband/core/sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
> index 2daf83276cdf..3de93517efe4 100644
> --- a/drivers/infiniband/core/sysfs.c
> +++ b/drivers/infiniband/core/sysfs.c
> @@ -77,7 +77,7 @@ struct port_table_attribute {
> struct port_attribute attr;
> char name[8];
> int index;
> - int attr_id;
> + __be16 attr_id;
> };
>
> static ssize_t port_attr_show(struct kobject *kobj,
> @@ -413,7 +413,7 @@ struct port_table_attribute port_pma_attr_ext_##_name = { \
> * Get a Perfmgmt MAD block of data.
> * Returns error code or the number of bytes retrieved.
> */
> -static int get_perf_mad(struct ib_device *dev, int port_num, int attr,
> +static int get_perf_mad(struct ib_device *dev, int port_num, __be16 attr,
> void *data, int offset, size_t size)
> {
> struct ib_mad *in_mad;
> --
> 1.8.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
