Re: [PATCH for-next 2/2] IB/core: Use hop-limit from IP stack for RoCE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 03, 2016 at 03:59:11PM +0200, Matan Barak wrote:
> @@ -434,6 +434,7 @@ int ib_init_ah_from_wc(struct ib_device *device, u8 port_num,
>  	int ret;
>  	enum rdma_network_type net_type = RDMA_NETWORK_IB;
>  	enum ib_gid_type gid_type = IB_GID_TYPE_IB;
> +	int hoplimit = grh->hop_limit;

>  		ah_attr->grh.flow_label = flow_class & 0xFFFFF;
> -		ah_attr->grh.hop_limit = 0xFF;
> +		ah_attr->grh.hop_limit = hoplimit;

No, this is wrong for IB. Please be careful to follow the IB
specification language for computing a hop limit on a reversible path.

No idea about rocee, but I can't believe using grh->hop_limit is right
there either.

Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux