On Mon, Dec 28, 2015 at 06:05:46PM -0500, ira.weiny wrote:
>
> Will it hurt to rearm? The way the code stands I think the worse that will
> happen is an extra work item scheduled and an ib_poll_cq call.
If you re-arm unconditionally you call for extra interrupts which you
can do without. When you break the loop of processing completions since
you exhausted the quota, you queue the work so you can continue
processing completions in the next time slot of the work task. After
queueing the work you should call "return" instead of "break".
If you processed all the completions before reaching
MAD_COMPLETION_PROC_LIMIT you will exit the while loop and then
re-arming can take place.
>
> I'm not quite sure what you mean about moving the ib_req_notify_cq outside of
> the while loop. It seems like to do what you say we would need another work
> item which just does ib_poll_cq. Is that what you meant?
>
> Ira
>
> >
> > > @@ -2574,6 +2587,11 @@ static void ib_mad_completion_handler(struct work_struct *work)
> > > }
> > > } else
> > > mad_error_handler(port_priv, &wc);
> > > +
> > > + if (++count > MAD_COMPLETION_PROC_LIMIT) {
> > > + queue_work(port_priv->wq, &port_priv->work);
> > > + break;
> > > + }
> > > }
> > > }
> > >
> > > --
> > > 1.8.2
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
