Re: [PATCH V1 0/3] Add cross-channel support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/24/2015 5:31 AM, Doug Ledford wrote:
On 12/20/2015 12:16 PM, Leon Romanovsky wrote:
Leon Romanovsky (3):
   IB/core: Align coding style of ib_device_cap_flags structure
   IB/core: Add cross-channel support
   IB/mlx5: Add driver cross-channel support

  drivers/infiniband/core/uverbs_cmd.c |  5 ++-
  drivers/infiniband/hw/mlx5/cq.c      |  7 +++-
  drivers/infiniband/hw/mlx5/main.c    |  3 ++
  drivers/infiniband/hw/mlx5/mlx5_ib.h | 16 ++++++++
  drivers/infiniband/hw/mlx5/qp.c      | 54 ++++++++++++++++++++++-----
  include/linux/mlx5/qp.h              |  3 ++
  include/rdma/ib_verbs.h              | 71 +++++++++++++++++++++---------------
  7 files changed, 117 insertions(+), 42 deletions(-)


I took the series as is.  Please make sure to resubmit the libibverbs portion of these changes with the requested man page updates.

Doug,

Wait.

We had consensus among the reviewers that the 1st patch ("IB/core: Align coding style of ib_device_cap_flags structure") is wrong cleanup which basically is (1) unneeded (2) creates more damage (git blame and such, non-applicable to uapi, more) than benefit, etc -- finally Leon was convinced too [1].

Leon will re-spin in the coming 1-2 hours V2, could please pick it instead of V1, when people agree on direction X and you are not against it, lets do X and not Y.

thanks,

Or.

[1] http://marc.info/?t=145061068000003&r=1&w=2


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux