On Mon, 21 Dec 2015, Leon Romanovsky wrote:
> On Mon, Dec 21, 2015 at 08:42:53AM -0600, Christoph Lameter wrote:
> > Code cleanup to remove multicast specific code from ipoib_main.c
> >
> > The removal of a list of multicast groups occurs in three places.
> > Create a new function ipoib_mcast_remove_list(). Use this new
> > function in ipoib_main.c too.
> > That in turn allows the dropping of two functions that were
> > exported from ipoib_multicast.c for expiration of mc groups.
> >
> > Reviewed-by: Iraq Weiny <ira.weiny@xxxxxxxxx>
> Iraq Weiny --> Ira Weiny
Ohh.. Bad typo.
> > +void ipoib_mcast_remove_list(struct net_device *dev, struct list_head *remove_list)
> Will it be beneficial to inline this function?
As far as I know it is not run in a latency critical context and the code
is too heavy for that. In particular we are calling other functions that
are not inlined.
> > +{
> > + struct ipoib_mcast *mcast, *tmcast;
> > +
> > + list_for_each_entry_safe(mcast, tmcast, remove_list, list) {
> > + ipoib_mcast_leave(dev, mcast);
> > + ipoib_mcast_free(mcast);
> > + }
> > +}
> > +
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
