On Mon, Dec 21, 2015 at 8:37 AM, Leon Romanovsky <leon@xxxxxxx> wrote: > On Mon, Dec 21, 2015 at 8:22 AM, ira.weiny <ira.weiny@xxxxxxxxx> wrote: >> On Sun, Dec 20, 2015 at 12:16:09PM +0200, Leon Romanovsky wrote: >>> From: Leon Romanovsky <leonro@xxxxxxxxxxxx> >>> Modify enum ib_device_cap_flags such that other patches which add new >>> enum values pass strict checkpatch.pl checks. >>> - IB_DEVICE_RESERVED = (1<<16), /* old SEND_W_INV */ >>> - IB_DEVICE_MEM_WINDOW = (1<<17), >>> + IB_DEVICE_RESIZE_MAX_WR = (1 << 0), > 2. Change the whole file => the work with "git blame" will be less > straightforward. Agree. Leon, I don't think we need to take checkpatch-ing of things to that level. Indeed, we should make sure that whole new enums and such are done right -- but avoid touching core structs/enums in a manner that disallows simple git blaming of things, which is very useful for new comers and old suffers. For example, the networking community keeps adding IFF_YYY values to include/linux/netdevice.h :: enum netdev_priv_flags without fixing checkpatch complaint on missing spaces before/after the << shift sign. > I will do the change across whole file, If Doug accepts such change. Please don't... simple git blame is very powerful tool for kernel developers everyday work. Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
