On 12/17/2015 1:54 PM, Christoph Lameter wrote: > On Thu, 17 Dec 2015, Hal Rosenstock wrote: >> ClassPortInfo is per class not per class per port so need to indicate to >> get_mad whether a port is supplied or not or conditionalize based on >> attr ID. > > I thought a port is always supplied since we get the info for a particular > port and the directory only exists if there is a port? Yes, but there is no port (PortSelect) field in ClassPortInfo attribute unlike the PortCounters and PortExtendedCounters attributes. >>> - ret = sysfs_create_group(&p->kobj, &pma_group); >>> + ret = sysfs_create_group(&p->kobj, >>> + port_check_extended_counters(device, port_num) ? >>> + &pma_group_ext : >>> + &pma_group); >> >> PortExtendedCounters does not have all the error counters in >> PortCounters so this isn't an either or. When extended port counters are >> supported should still include the original port counters with the >> exception of the [xmit rcv] [pkts data] which should come from the >> extended counters. > > The original port counters are still included. The _ext table refers to > both extended and regular counters. Good; I missed that; sorry. -- Hal -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
