>
> On Fri, 11 Dec 2015, ira.weiny wrote:
>
> > I think I would rather see this called something like
> >
> > ipoib_add_to_list_sendonly
> >
> > Or something...
> >
> > Calling it iboib_check* sounds like it should return a bool.
>
> Hmm... It only adds the multicast group if the check was successful.
>
> How about
>
> ipoib_check_and_add_mcast_sendonly()
Better.
>
>
> > > +void ipoib_check_mcast_sendonly(struct ipoib_dev_priv *priv, u8
> *mgid,
> > > + struct list_head *remove_list)
> > > +{
> > > + /* Is this multicast ? */
> > > + if (*mgid == 0xff) {
> >
> > Odd to see a mgid variable which is only u8?
> >
> > How about "gid_prefix"?
>
> That is only used in the qib driver and there it is a field.
>
> mgid is a pointer to the seres of bytes of the MGID and the first byte of that
> signifies multicast if 0xff....
Understood, I misread the code at first.
Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
