> Thanks for looking at the code. I am still not understanding your point. >> Old code: >> usnic_vnic_res_free_cnt(vnic, type) == 0 and cnt == 1 will return EINVAL > Yes: > if (0 < 1 || 1 < 1 || !owner) > return -EINVAL; >> New code >> snic_vnic_res_free_cnt(vnic, type) == 0 and cnt == 1 will pass and will >> pass te "if (cnt > 0)" check below and will decrease free_cnt variable >> to be below zero. > This I don't understand. The following still fails with -EINVAL. > if (0 < 1 || 1 < 0 || !owner) > return -EINVAL; Thank you for clarifying it. I don't know why I missed first comparison. Sorry for bothering you. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html