On Mon, Nov 23, 2015 at 11:58:29AM -0700, Jason Gunthorpe wrote: > > +#define IB_REG_LKEY (ib_reg_scope_t)0x0000 > > +#define IB_REG_RKEY (ib_reg_scope_t)0x0001 > > Wrap in () just for convention? Ok. > Maybe > > unsigned int acc = ib_scope_to_access(scope); > if ((scope & (IB_REG_RKEY | IB_REG_OP_RDMA_READ)) == (IB_REG_RKEY | IB_REG_OP_RDMA_READ)) > acc |= IB_ACCESS_LOCAL_WRITE; > > return acc; > > Makes it a bit clearer what the only difference is. I can do that. > Is this enough to purge the cap test related to this? I thought we didn't even have a cap check for it yet? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
