RE: [PATCH] IB/mad: In validate_mad, validate CM method and attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +		/* CM attributes other than ClassPortInfo only use Send method
> */
> > +		if (mad_hdr->mgmt_class == IB_MGMT_CLASS_CM) {
> > +			if (mad_hdr->attr_id != IB_MGMT_CLASSPORTINFO_ATTR_ID) {
> > +				if (mad_hdr->method != IB_MGMT_METHOD_SEND)
> > +					goto out;
> > +			} else if (mad_hdr->method != IB_MGMT_METHOD_GET_RESP)
> > +				goto out;
> > +		}
> 
> Doesn't this invalidate a CM Get(ClassPortInfo) mad?

I believe this does.  I think you could remove the else if clause and let the received MAD get passed to the CM.  It would be dropped there as unsupported.  The net result is likely the same.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux