> > - if (WARN_ON(vl > 8)) > > - return NULL; > > + /* NOTE This should only happen if SC->VL changed after the initial > > + * checks on the QP/AH > > + * Default will return engine 0 below > > + */ > > + if (unlikely(vl >= num_vls)) { > > Can you prove that unlikely() makes a measured difference here? If not, > please remove it. If you can, please provide the proof in the changelog > when you resend it. Unfortunately, I can't prove this so will remove in v2. Thanks, Jubin John -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html