On Tue, Oct 20, 2015 at 4:08 PM, Sagi Grimberg <sagig@xxxxxxxxxxxxxxxxxx> wrote: >>> I think this is very useful to have and I'd love having it in 4.4, >>> does anyone have any other comments on this patch? >> Were we ever presented with performance gains achieved using the patch? > Can you explain what you mean by performance gains? My understanding is > that this patch is not performance critical. It just replaces each and > every ULP device attributes caching. oops, sorry, I was referring to the patch that deals with re-structuring of struct ib_wc, so... (1) did we even got performance gains achieved using **that** patch? (2) re this one, as I wrote in the past, I am in favor of simple caching of struct ib_device_attr on struct ib_device (best with pointer) and not adding 333 fields to struct ib_device, I don't see the benefit from this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
