On 19/10/2015 21:19, Jason Gunthorpe wrote: > On Mon, Oct 19, 2015 at 09:09:25PM +0300, Haggai Eran wrote: >> When discussing the patches to demux ids in rdma_cm instead of ib_cm, it >> was decided that it is best to use the P_Key value in the packet headers >> [1]. However, some drivers are currently unable to send correct P_Key in >> GMP headers. > > You should explicitly describe the broken drivers in the commit text. These are mlx5 and ipath. I'll add them to the commit message. > I thought mlx5 was fixed for receive already? I'm confused why we need > this. mlx5 had two issues related to GSI pkeys. The issue that was fixed was that it treated the pkey value returned by the hardware in receive completions as a pkey_index. The remaining issue is that it doesn't respect the ib_send_wr.ud.pkey_index field when sending. With the current state of things, cma will try to look for an ipoib net dev matching the BTH pkey of the request, but if the sender is mlx5 or ipath, the BTH pkey would be the default pkey. If the request was intended for a different pkey, cma won't find a matching netdev and will throw away the request. Haggai -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
