Re: [PULL REQUEST] Please pull rdma.git

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 8, 2015 at 9:24 AM, Doug Ledford <dledford@xxxxxxxxxx> wrote:
>
> Matan Barak (5):
>       net: Add info for NETDEV_CHANGEUPPER event

Why the hell is this coming in through the infiniband tree? Especially
with the networking tree having done the same thing differently?

I see that Stephen Rothwell reported this almost two weeks ago, and
informed you.

The commit you send me, though, has been rebased since then, BUT IT
STILL EXISTS.

The commit is wrong, and you knew about it. So tell me, why the hell
should I pull this shit?

Oh, yes, I can fix it in the merge. This is not a "I can't resolve
this pull request" email. Resolving it in favor of the existing
networking infrastructure is easy.

This is a "why should I even bother?" email.

The two different commits have very similar logic, somewhat similar
names, but the details are different. Both were written by somebody
with a "mellanox.com" address.

One huge glaring difference is that one of them went through the
networking maintainer, which matters a great deal since this is a
networking notifier.

I did the pull, did most of the resolve, but then decided that I don't
even want to merge this considering how questionable it was.

This needs a good explanation, because for now this pull request is dead to me.

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux