On Wed, Aug 19, 2015 at 07:09:18PM +0300, Sagi Grimberg wrote: > Ok, I was also thinking on moving the access flags > to the work request again. Yes, with the current code I don't think we need it in the MR. > I'd prefer to get this right with a different helper like Steve > suggested: > int rdma_access_flags(int mr_roles); We can start with that. In the long run we really want to have two higher level helpers to RDMA READ a scatterlist: - one for iWARP that uses an FR and RDMA READ WITH INVALIDATE - one of IB-like transports that just uses a READ with the local lkey Right now every ULP that wants to support iWarp needs to duplicate that code. This leads to some curious situations like the NFS server apparently always using FRs if available for this if my reading of svc_rdma_accept() is correct, or the weird parallel code pathes for IB vs iWarp in RDS: hch@brick:~/work/linux/net/rds$ ls ib* ib.c ib_cm.c ib.h ib_rdma.c ib_recv.c ib_ring.c ib_send.c ib_stats.c ib_sysctl.c hch@brick:~/work/linux/net/rds$ ls iw* iw.c iw_cm.c iw.h iw_rdma.c iw_recv.c iw_ring.c iw_send.c iw_stats.c iw_sysctl.c -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
