Re: [PATCH for-next 2/7] IB/core: Allow setting create flags in QP init attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 17, 2015 at 7:47 PM, Jason Gunthorpe
<jgunthorpe@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Sun, Aug 16, 2015 at 07:05:28PM +0300, Eran Ben Elisha wrote:
>
>> -     if (attr.create_flags) {
>> +     if (attr.create_flags & ~IB_QP_CREATE_BLOCK_MULTICAST_LOOPBACK) {
>>               ret = -EINVAL;
>>               goto err_put;
>
> Shouldn't EINVAL still happen if the driver doesn't support this
> feature?
>
> Jason

I expect the same behavior as if ib_create_qp was called with
IB_QP_CREATE_BLOCK_MULTICAST_LOOPBACK in the create_flags.
This is not a new flag, and driver should fail the command if not supported.

Eran.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux