On Wed, Aug 5, 2015 at 8:16 PM, Jason Gunthorpe
<jgunthorpe@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Aug 05, 2015 at 06:34:26PM +0300, Amir Vadai wrote:
>> struct ib_uverbs_ex_query_device {
>> __u32 comp_mask;
>> + __u32 csum_caps;
>> __u32 reserved;
>> };
>
> Uh no.
>
>> @@ -221,6 +222,7 @@ struct ib_uverbs_odp_caps {
>> struct ib_uverbs_ex_query_device_resp {
>> struct ib_uverbs_query_device_resp base;
>> __u32 comp_mask;
>> + __u32 csum_caps;
>> __u32 response_length;
>> struct ib_uverbs_odp_caps odp_caps;
>> __u64 timestamp_mask;
>
> Also totally wrong.
>
> Or, WTF? why is something so screwed up like this being sent to the list?
> NAK
Jason,
So -- shit happens, I am trying to figure out if an internal review
has been done, b/c we do have some folks who terribly master the
extended uverbs framework, right...? if this is wrong it's good that
you rejected the patch and even put it in WTF response, but again, I
see that the author is someone new to the upstream rdma stack and we
should encourage more people to participate... so you sent him back
home to do HW, let's see what this will yield.
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
