Re: [PATCH v4 40/50] IB/hfi1: add sysfs routines and documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 31, 2015 at 03:32:07PM +0000, Marciniszyn, Mike wrote:
> > > > > > +HFI1
> > > > > > +
> > > > > > +  The hfi1 driver also creates these additional files:
> > > > > > +
> > > > > > +   hw_rev - hardware revision
> > > >=20
> > > > I'm checking on this to see if it is indeed a duplicate.
> > > >=20
> > >
> > > Our hardware architect has indicated there is not PCIe equivalent for
> > > this = case.
> > 
> > Please get someone knowledgeable at Intel to look at this. There is a (rev 04)
> > when using lspci on my nic here. This seems to be the hardware revision.
> 
> I'm not sure what else to say other that the source for the sysfs
> file display is not from the PCI_REVISION_ID.

I think the lesson here is if you follow the PCI standards, and put
this kind of information in the config block (VPD, rev header, etc),
where it belongs, then you don't need to create questionable sysfs
files in your driver to get at the 2nd source..

If that wasn't done, the HW can't be changed, we are stuck with
wonky sysfs files.. Try and get it right next time <shrug>

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux